fix: apply strip_refreshing to output for errors #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudomorph
requested review from
jamengual,
lukemassa and
nitrocode
and removed request for
a team
pseudomorph
changed the title
pseudomorph
force-pushed
the
run_error_strip_refresh
branch
2 times, most recently
from
c738bc7 to
cbff893
Compare
|
Need to figure out test failures. They seem unrelated. |
pseudomorph
force-pushed
the
run_error_strip_refresh
branch
from
cbff893 to
96b392b
Compare
|
I'm pretty confused on the test errors here. When I run the tests locally against main, they still show up. Traversing down the git history doesn't seem to change much for test status against recent commits. |
|
@pseudomorph your test failures is fixed in #4462 :) |
pseudomorph
force-pushed
the
run_error_strip_refresh
branch
2 times, most recently
from
00634bf to
22393d1
Compare
pseudomorph
force-pushed
the
run_error_strip_refresh
branch
from
22393d1 to
c719e96
Compare
pseudomorph
force-pushed
the
run_error_strip_refresh
branch
from
c719e96 to
36dbb4f
Compare
chenrui333
approved these changes
May 21, 2024
|
@pseudomorph can you followup and add test for this change? Thanks! |
1 task
ragne
pushed a commit
to ragne/atlantis
that referenced
this pull request
May 23, 2024
Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
|
Wird, strip_refreshing dosen't do anything now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Apply
strip_refreshingformatting to output prior to use in error messaging.why
When using a custom run command for the plan step - an error with Terraform can produce very long outputs regarding refreshing. #3518 addressed stripping the refreshing comments out for successful commands, but they still come through in errors. This addresses that.
tests
references