Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make api plan apply support workflow hooks #4482

Merged
merged 5 commits into from
May 1, 2024
Merged

feat: make api plan apply support workflow hooks #4482

merged 5 commits into from
May 1, 2024

Conversation

keidarcy
Copy link
Contributor

what

Make https://www.runatlantis.io/docs/api-endpoints.html#post-api-plan plan and apply API support pre and post workflow hooks

why

There is an issue like #4194
pre / post workflow hooks should run when using API.
Also asked in slack, it's not on purpose to not run hooks.

tests

  • I have tested my changes by run atlantis locally with a private repo

references

@keidarcy keidarcy requested review from a team as code owners April 25, 2024 13:30
@keidarcy keidarcy requested review from jamengual, lukemassa and nitrocode and removed request for a team April 25, 2024 13:31
@github-actions github-actions bot added the go Pull requests that update Go code label Apr 25, 2024
@jamengual jamengual added waiting-on-review Waiting for a review from a maintainer api-endpoints Adding API endpoints to Atlantis labels Apr 25, 2024
jamengual
jamengual approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @keidarcy Thanks for the contribution

@jamengual jamengual merged commit 267b2f1 into runatlantis:main May 1, 2024
24 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 22, 2024
Merged
1 task
@jamengual jamengual mentioned this pull request May 29, 2024
Closed
@keidarcy keidarcy deleted the api-endpoints-support-workflow-hooks branch October 5, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@lukemassa lukemassa Awaiting requested review from lukemassa lukemassa is a code owner automatically assigned from runatlantis/core-contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
api-endpoints Adding API endpoints to Atlantis go Pull requests that update Go code waiting-on-review Waiting for a review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keidarcy @jamengual