fix(docs): fix home header width so the menu doesn't jump around when navigating #4560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jippi
requested review from
GenPage,
lukemassa and
nitrocode
and removed request for
a team
chenrui333
approved these changes
May 14, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
The
homepage had a forcedmax-widthof960pxfor the top nav bar, making it look like this (pic 1)meaning that when you navigate to any other page, the top bar would "jump" and all icons/menus would get new placements, making for a surprising change in layout and "jolt" to the reading process (pic 2)
With this change, the top bar is consistently sized and placed across all pages (pic 3), making for a more consistent and easier to scan experience for folks
This is consistent with how the native VitePress them work as well
--
Navigating from homepage to docs and then going back and forth in history shows this clearly