-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Add link to Survey in top bar #4574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case folks dismiss the survey top bar, its still easily accessible
jippi
requested review from
jamengual,
lukemassa and
X-Guardian
and removed request for
a team
May 17, 2024 22:47
chenrui333
approved these changes
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @jippi! (Love that 📢 emoji 😆 )
1 task
terakoya76
pushed a commit
to terakoya76/atlantis
that referenced
this pull request
Dec 31, 2024
kvanzuijlen
pushed a commit
to kvanzuijlen/atlantis
that referenced
this pull request
Jan 4, 2025
Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case folks dismiss the survey top bar, its still easily accessible.
I've had folks at $DayJob ask about the survey link twice today, because they dismissed the banner out of habit (looks like a banner/cookie content block) without reading it first.
I personally dismissed it at work without thinking because I needed to go to the docs fix an issue for a engineer, and the bar was visually distracting and looked like marketing - didn't even think about it, just removed it like a cookie consent banner by pure habit
So been needing to go to the source code 3 times today to dig up the banner URL because of "click to dismiss"-habits, so thought it was likely other folks had similar experience.
Preview: https://deploy-preview-4574--runatlantis.netlify.app/