Fix issues with terraform execution. #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
fix-long-output
branch
from
a045c15 to
ee117d4
Compare
Previously I wrote a bunch of code to deal with terraform panicking. This code used a pipe as the stdout/err buffer and there was a bug because I wasn't reading off the pipe and it would get full. While testing a fix, I realized when Terraform panics, the previous code using CombinedOutput() just worked. As a result, I'm switching back to that code.
lkysow
force-pushed
the
fix-long-output
branch
from
ee117d4 to
5002397
Compare
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
==========================================
- Coverage 70.53% 70.49% -0.05%
==========================================
Files 63 63
Lines 4243 4223 -20
==========================================
- Hits 2993 2977 -16
+ Misses 1028 1026 -2
+ Partials 222 220 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I wrote a bunch of code to deal with terraform panicking.
This code used a pipe as the stdout/err buffer and there was a bug
because I wasn't reading off the pipe and it would get full.
While testing a fix, I realized when Terraform panics, the previous code
using CombinedOutput() just worked. As a result, I'm switching back to
that code.
Fixes #452