-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate mocks to mockery #4688
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
If switching to https://vektra.github.io/mockery/latest/migrating_to_packages/ e.g.
Or you could have the mocks adjacent to the interface if you wanted: |
@james0209 thanks for weighing in here, yeah, I was definitely thinking that I was going with the |
todos for this pr:
|
fixes #4664