chore: Use existing github env vars for e2e #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
chenrui333,
nitrocode and
X-Guardian
and removed request for
a team
chenrui333
approved these changes
Jul 8, 2024
jamengual
approved these changes
Jul 8, 2024
terakoya76
pushed a commit
to terakoya76/atlantis
that referenced
this pull request
Dec 31, 2024
kvanzuijlen
pushed a commit
to kvanzuijlen/atlantis
that referenced
this pull request
Jan 4, 2025
Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Use standard
ATLANTIS_env vars for configuring e2e instead of bespokeATLANTISBOTones.why
Consolidate and simplify.
This will also make #4582 a bit easier
tests
Ran ./scripts/e2e.sh manually.
references
Working towards: #4582