chore: Make e2e tests more vcs agnostic #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
lukemassa
force-pushed
the
more_vcs_isolation_in_e2e_tests
branch
from
7228f3a to
d3a710e
Compare
chenrui333
approved these changes
Aug 12, 2024
jamengual
approved these changes
Aug 12, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
DeleteBranch()take the bare branch name, notheads/<branchName>(the latter is apparently a github implementation detail)failurewhereas gitlab has a state calledfailed, both of which mean the same thing, and indicate that the run is donewhy
Make the e2e tests more agnostic to which VCS they are being run on. This will make it more straightforward to add new VCSs.
tests
The e2e tests themselves passing should be good enough.
references
Working towards #4582.