chore: Improve process management in e2e test #4840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
GenPage,
nitrocode and
X-Guardian
and removed request for
a team
lukemassa
changed the title
lukemassa
force-pushed
the
improve_process_management_in_e2e_test
branch
from
89aafd5 to
db0335d
Compare
chenrui333
approved these changes
Aug 14, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Make it so when the e2e.sh script ends, it also cleans up the background processes of atlantis and ngrok.
Additionally, quit the script early if atlantis or ngrok fail to start up.
why
While I was working on the e2e golang code, it ended up that multiple copies of both atlantis and ngrok were running on my computer, which got confusing.
Another annoyance was if atlantis or ngrok fail to start, the script kept going, then failed in a confusing way. Now the script makes sure the process stays up after the two second pause.
tests
I ran the script locally. Also the CI ran successfully, including my new output.
references