fix: GitHub - Support Token File for Git Commands #5067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Muru Paenga <meringu@gmail.com>
meringu
requested review from
chenrui333,
lukemassa and
X-Guardian
and removed request for
a team
X-Guardian
changed the title
X-Guardian
approved these changes
Nov 5, 2024
|
Thanks for this @meringu. Can you test with one of the following container images: dev-debian-240b6b1 or dev-alpine-240b6b1 |
|
Sorry for the delay @X-Guardian. I had mounted my secret with a K8s subPath, which meant the token wasn't rotating on the container volume during my tests. I've corrected that, and can now run plans over an hour long, proving that the token is being rotated, as my tokens only last one hour. This looks ready to go from my point of view. Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Quick follow up to #3208.
I noticed during testing that we need to also set the token file here. I believe I must have been testing by running against a PR with a commit that was already checked out on the persistent volume. Atlantis detected that it didn't need to perform a
git clonecommand.I've updated my testing to include testing with a new PR and new commit, forcing a clean checkout.
why
The GitHub client credentials are separate to the git client credentials, so we must set the token file here too when configuring Atlantis for a token file rather than the token directly.
tests
Tested this with a clean clone in my environment.
references
#3208