Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Regenerates mock files with pegomock v4.1.0 #5090

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

tkasuz
Copy link
Contributor

@tkasuz tkasuz commented Nov 14, 2024

what

The current version of pegomock is v4.1.0, but the mock files in use are still generated with v4.0.0. In v4.1.0, certain mock generation variables have been renamed.

rename mockgen variables like _ret1, _result and _params not to conflict with method args by @krrrr38 in petergtz/pegomock#124

why

tests

  • I have tested my changes by local

references

renovate PR is #4832

@tkasuz tkasuz requested review from a team as code owners November 14, 2024 14:46
@tkasuz tkasuz requested review from jamengual, lukemassa and X-Guardian and removed request for a team November 14, 2024 14:46
@dosubot dosubot bot added the refactoring Code refactoring that doesn't add additional functionality label Nov 14, 2024
Signed-off-by: tkasuz <63289889+tkasuz@users.noreply.github.com>
@tkasuz tkasuz force-pushed the pegomock-v4.1.0-regen-mock branch from e730c0b to b6cdd7d Compare November 15, 2024 03:02
@X-Guardian
Copy link
Contributor

Thanks for this @tkasuz. Would you mind also taking a look at CONTRIBUTING.md#mocks and see if it needs updating too. That initial install comment looks out-of-date at least.

@X-Guardian X-Guardian added the waiting-on-response Waiting for a response from the user label Nov 16, 2024
- Replaced outdated install command with the latest one
- Removed mention of go get, as it is no longer required for installing the binary

Signed-off-by: tkasuz <63289889+tkasuz@users.noreply.github.com>
@tkasuz
Copy link
Contributor Author

tkasuz commented Nov 16, 2024

@X-Guardian Updated some outdated instructions 👍

Copy link
Contributor

@X-Guardian X-Guardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tkasuz, looks good.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 16, 2024
@X-Guardian X-Guardian merged commit 5e0f854 into runatlantis:main Nov 16, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code lgtm This PR has been approved by a maintainer provider/azuredevops provider/github provider/gitlab refactoring Code refactoring that doesn't add additional functionality waiting-on-response Waiting for a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants