Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append terraform binary dir to PATH when running custom commands #678

Merged
merged 3 commits into from
Jul 16, 2019

Conversation

maximede
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #678 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
- Coverage   72.37%   72.35%   -0.02%     
==========================================
  Files          61       61              
  Lines        4658     4662       +4     
==========================================
+ Hits         3371     3373       +2     
- Misses       1037     1039       +2     
  Partials      250      250
Impacted Files Coverage Δ
server/events/terraform/terraform_client.go 79.03% <0%> (-0.86%) ⬇️
server/events/runtime/run_step_runner.go 100% <100%> (ø) ⬆️
server/server.go 65.94% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26c7df1...92aaecf. Read the comment docs.

server/events/runtime/run_step_runner.go Outdated Show resolved Hide resolved
server/events/runtime/run_step_runner.go Outdated Show resolved Hide resolved
server/events/runtime/run_step_runner.go Outdated Show resolved Hide resolved
server/events/runtime/run_step_runner_test.go Outdated Show resolved Hide resolved
server/events/terraform/terraform_client.go Show resolved Hide resolved
Add comments on new fields/methods
Use Os.Getenv to build the new PATH
@maximede
Copy link
Contributor Author

@lkysow I pushed the requested changes. Let me know if you need anything else from me.

@lkysow
Copy link
Member

lkysow commented Jun 19, 2019

👍 thanks, I won't be able to take a look until next week unfortunately.

@lkysow lkysow merged commit 8180f35 into runatlantis:master Jul 16, 2019
@lkysow
Copy link
Member

lkysow commented Jul 16, 2019

Thanks Maxime, sorry for the delay in merging.

@maximede maximede deleted the bin-dir-path branch August 26, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants