-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .hcl to supported file filter #748
Conversation
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 62 62
Lines 4728 4728
=======================================
Hits 3416 3416
Misses 1057 1057
Partials 255 255
Continue to review full report at Codecov.
|
@lkysow any chance of this shipping at least as a short-term measure until you can add a top-level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jesse,
Thanks for the PR. Can you scope this down further to only matching terragrunt.hcl
? This won't break backwards compatibility (as much).
Also please add a test for this change and document the new config here: https://www.runatlantis.io/docs/custom-workflows.html#terragrunt
@lkysow I made those changes, would you mind reviewing again? 🙏 |
@@ -176,6 +176,41 @@ Atlantis will need to have the `terragrunt` binary in its PATH. | |||
If you're using Docker you can build your own image, see [Customization](/docs/deployment.html#customization). | |||
::: | |||
|
|||
#### Terragrunt Autoplan Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you call this section Terragrunt 0.19+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this actually applies to Terragrunt 0.18 as well. I think it could be confusing to call it Terragrunt 0.19+ since it really applies to all versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is the section above where we tell people to list all the projects obsolete then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there still might be a place for the above config. It depends on how you're using Terragrunt, really. If you have just a few modules then listing out each project works well. But if you have a ton of modules (like we do) then it makes more sense to use autoplan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, thanks for the PR! 🚢
Quick fix for #728 until this is implemented.
Allows for using Atlantis with Terragrunt 0.19 style
terragrunt.hcl
config.All tests passing.