Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .hcl to supported file filter #748

Merged
merged 7 commits into from
Aug 26, 2019
Merged

Conversation

jessebye
Copy link

Quick fix for #728 until this is implemented.

Allows for using Atlantis with Terragrunt 0.19 style terragrunt.hcl config.

All tests passing.

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #748 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #748   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files          62       62           
  Lines        4728     4728           
=======================================
  Hits         3416     3416           
  Misses       1057     1057           
  Partials      255      255
Impacted Files Coverage Δ
server/events/project_finder.go 93.82% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc478a5...186d761. Read the comment docs.

@jessebye
Copy link
Author

@lkysow any chance of this shipping at least as a short-term measure until you can add a top-level autoplan.when_modified? We are stuck not being able to use atlantis after the Terragrunt 0.19/Terraform 0.12 upgrade due to this issue.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jesse,
Thanks for the PR. Can you scope this down further to only matching terragrunt.hcl? This won't break backwards compatibility (as much).

Also please add a test for this change and document the new config here: https://www.runatlantis.io/docs/custom-workflows.html#terragrunt

@jessebye
Copy link
Author

@lkysow I made those changes, would you mind reviewing again? 🙏

runatlantis.io/docs/custom-workflows.md Outdated Show resolved Hide resolved
server/events/project_finder.go Outdated Show resolved Hide resolved
server/events/project_finder_test.go Show resolved Hide resolved
@@ -176,6 +176,41 @@ Atlantis will need to have the `terragrunt` binary in its PATH.
If you're using Docker you can build your own image, see [Customization](/docs/deployment.html#customization).
:::

#### Terragrunt Autoplan Configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you call this section Terragrunt 0.19+

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this actually applies to Terragrunt 0.18 as well. I think it could be confusing to call it Terragrunt 0.19+ since it really applies to all versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is the section above where we tell people to list all the projects obsolete then?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there still might be a place for the above config. It depends on how you're using Terragrunt, really. If you have just a few modules then listing out each project works well. But if you have a ton of modules (like we do) then it makes more sense to use autoplan.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thanks for the PR! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants