Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow when_modified files to be excluded #865

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Allow when_modified files to be excluded #865

merged 1 commit into from
Nov 27, 2019

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Nov 27, 2019

I noticed that setting when_modified to something like ["*.tf", "!exclude-me.tf] with a modified list of exclude-me.tf still resulted in a plan automatically running. This PR allows files to be excluded using .dockerignore's exclusion syntax, i.e. prepending a ! to the path.

(from #847)

Closes #847 (rebased those commits).

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #865 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
+ Coverage   71.82%   71.88%   +0.05%     
==========================================
  Files          65       65              
  Lines        5214     5221       +7     
==========================================
+ Hits         3745     3753       +8     
+ Misses       1184     1183       -1     
  Partials      285      285
Impacted Files Coverage Δ
server/events/project_finder.go 94.38% <100%> (+0.55%) ⬆️
server/events/vcs/azuredevops_client.go 73.12% <0%> (-0.93%) ⬇️
server/events/yaml/raw/global_cfg.go 0% <0%> (ø) ⬆️
server/events/event_parser.go 85.92% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf0624...ce72bd4. Read the comment docs.

@lkysow lkysow merged commit 1750a67 into master Nov 27, 2019
@lkysow lkysow deleted the when-modified branch November 27, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant