Skip to content

Commit

Permalink
✨ expose init-shared-path readOnly var (#393)
Browse files Browse the repository at this point in the history
* ✨ expose init-shared-path readOnly var

* Update charts/atlantis/values.schema.json

Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>

* ⬆️ bump minor version

* 📝 update doc template + gen

---------

Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
  • Loading branch information
vmdude and GMartinez-Sisti committed Jun 12, 2024
1 parent 7693bfd commit 420b19d
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 6 deletions.
2 changes: 1 addition & 1 deletion charts/atlantis/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: v1
appVersion: v0.28.1
description: A Helm chart for Atlantis https://www.runatlantis.io
name: atlantis
version: 5.1.1
version: 5.1.2
keywords:
- terraform
home: https://www.runatlantis.io
Expand Down
5 changes: 3 additions & 2 deletions charts/atlantis/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ extraManifests:
| initConfig.script | string | Check values.yaml. | Script to run on the init container. |
| initConfig.securityContext | object | `{}` | Security context for the container. |
| initConfig.sharedDir | string | `"/plugins"` | SharedDir is set as env var INIT_SHARED_DIR. |
| initConfig.sharedDirReadOnly | bool | `true` | |
| initConfig.sizeLimit | string | `"100Mi"` | Size for the shared volume. |
| initConfig.workDir | string | `"/tmp"` | |
| initContainers | list | `[]` | Optionally specify init containers manifests to be added to the Atlantis pod. Check values.yaml for examples. |
Expand Down Expand Up @@ -384,9 +385,9 @@ To perform a smoke test of the deployment (i.e. ensure that the Atlantis UI is u

## Update documentation

Documentations is auto-generated using [helm-docs](https://github.com/norwoodj/helm-docs).
Documentation is auto-generated using [helm-docs](https://github.com/norwoodj/helm-docs).

To update run the follwogin (from the root path of the repository):
To update run the following (from the root path of the repository):

1. If required, update `charts/atlantis/README.md.gotmpl`
2. Run `make docs`
Expand Down
4 changes: 2 additions & 2 deletions charts/atlantis/README.md.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,9 @@ To perform a smoke test of the deployment (i.e. ensure that the Atlantis UI is u

## Update documentation

Documentations is auto-generated using [helm-docs](https://github.com/norwoodj/helm-docs).
Documentation is auto-generated using [helm-docs](https://github.com/norwoodj/helm-docs).

To update run the follwogin (from the root path of the repository):
To update run the following (from the root path of the repository):

1. If required, update `charts/atlantis/README.md.gotmpl`
2. Run `make docs`
Expand Down
2 changes: 1 addition & 1 deletion charts/atlantis/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ spec:
{{- if .Values.initConfig.enabled }}
- name: init-shared-path
mountPath: {{ .Values.initConfig.sharedDir }}
readOnly: true
readOnly: {{ .Values.initConfig.sharedDirReadOnly }}
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
Expand Down
4 changes: 4 additions & 0 deletions charts/atlantis/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1010,6 +1010,10 @@
"type": "string",
"description": "sharedDir is set as env var INIT_SHARED_DIR"
},
"sharedDirReadOnly": {
"type": "boolean",
"description": "Sets permissions level for the SharedDir in the main container to ReadWrite when true or ReadWrite when false"
},
"workDir": {
"type": "string",
"description": "Starting directory for the script"
Expand Down
1 change: 1 addition & 0 deletions charts/atlantis/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,7 @@ initConfig:
imagePullPolicy: IfNotPresent
# -- SharedDir is set as env var INIT_SHARED_DIR.
sharedDir: /plugins
sharedDirReadOnly: true
workDir: /tmp
# -- Size for the shared volume.
sizeLimit: 100Mi
Expand Down

0 comments on commit 420b19d

Please sign in to comment.