Add support for installing a GitHub App under an organization #263
Conversation
tampakrap
changed the title
tampakrap
force-pushed
the
add_support_for_gh_app_org_installation
branch
from
5aca7cf
to
ed27ad8
Compare
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| # Replace this with your own repo allowlist: | |||
| orgAllowlist: <replace-me> | |||
| #githubAppOrg: myorgname | |||
There was a problem hiding this comment.
Could we move this to githubApp?
There was a problem hiding this comment.
Unfortunately it can't be under githubApp, because the org needs to be set up before the github app is created and set up in atlantis
There was a problem hiding this comment.
Hi @tampakrap, can you please clarify why it wouldn't work? We can still set the value on the ATLANTIS_GH_ORG, it's just a different name for the variable.
|
Cant you just set this under |
sure, that is what I'm currently doing |
GMartinez-Sisti
added
waiting-on-response
|
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
what
Adding a new optional environment variable
ATLANTIS_GH_ORG, which is equivalent to the--gh-orgargument.Relevant documentation: https://www.runatlantis.io/docs/server-configuration.html#gh-org
why
The installation of the GitHub App under a GitHub organization needs this extra argument / env var on the initial run.
Relevant documentation: https://www.runatlantis.io/docs/access-credentials.html#github-app
After the initial run, and after the GitHub App is installed under the desired organization, this env var can be commented out / unset again.
tests
I have tested locally by successfully creating a new GitHub App under an organization.
references
https://www.runatlantis.io/docs/server-configuration.html#gh-org
https://www.runatlantis.io/docs/access-credentials.html#github-app