-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for installing a GitHub App under an organization #263
Add support for installing a GitHub App under an organization #263
Conversation
5aca7cf
to
ed27ad8
Compare
@@ -8,6 +8,7 @@ | |||
|
|||
# Replace this with your own repo allowlist: | |||
orgAllowlist: <replace-me> | |||
#githubAppOrg: myorgname |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move this to githubApp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately it can't be under githubApp, because the org needs to be set up before the github app is created and set up in atlantis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tampakrap, can you please clarify why it wouldn't work? We can still set the value on the ATLANTIS_GH_ORG
, it's just a different name for the variable.
Cant you just set this under |
sure, that is what I'm currently doing |
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
what
Adding a new optional environment variable
ATLANTIS_GH_ORG
, which is equivalent to the--gh-org
argument.Relevant documentation: https://www.runatlantis.io/docs/server-configuration.html#gh-org
why
The installation of the GitHub App under a GitHub organization needs this extra argument / env var on the initial run.
Relevant documentation: https://www.runatlantis.io/docs/access-credentials.html#github-app
After the initial run, and after the GitHub App is installed under the desired organization, this env var can be commented out / unset again.
tests
I have tested locally by successfully creating a new GitHub App under an organization.
references
https://www.runatlantis.io/docs/server-configuration.html#gh-org
https://www.runatlantis.io/docs/access-credentials.html#github-app