-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't define resources #297
Conversation
We should not specify any resources. This entire section should default to nothing.
|
@nitrocode can this be merged without bumping the chart version? Or will a github action handle that? |
@jseiser The github action will not handle it. It will need a bump. |
The lint check fixes now catches a missing version bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just think this should bump patch instead of minor since it's not implementing a feature.
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Updated as required. |
@GMartinez-Sisti Any chance we can get the chart version updated again, and get this one merged? Thanks, |
Maintainers have write access to this branch. |
We enabled parallel plans, and now we are hitting this same problem. a MR is created and atlantis dies. |
@rissson can you please bump the version? usually, the user does this instead of us |
what
Remove cpu limits from the atlantis container
why
Atlantis simply dies on simple tasks like
terraform init
with the current configuration.tests
references
https://home.robusta.dev/blog/stop-using-cpu-limits