-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set aws file secrets as individual files #385
base: main
Are you sure you want to change the base?
Conversation
Thanks @ryan-dyer-sp! Can you please provide an example on |
IDK what you're asking for here. https://github.com/runatlantis/helm-charts/blob/main/charts/atlantis/values.yaml#L128-L139 isnt changing. Its just mapping the individual elements within the secret to filenames instead of mounting the entire secret as a volume. Thanks |
e1cfad6
to
e9ee23e
Compare
Hi!
Please check my comment, I'm trying to understand if the values are supposed to change.
This is a good idea 👍 |
@GMartinez-Sisti Anything else needed? |
I'll look into this soon! 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready to go! Please see the comment below and also bump the minor version for the chart and it will be good to merge. Sorry for taking so long to review!
Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
what
creates config and credentials as files within .aws instead of mounting entire secret as .aws.
why
This allows for other directories (.aws/cli, .aws/sso) which need to be created/used by the CLI itself for caching to exist.
tests
tested via various configuration of helm values to receive desired result. Running in own environment the case where aws.config is specified. Does assume that config/credentials is never specified along with awsSecretName.
references
closes #380