-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dnsConfig to Atlantis #397
Conversation
Hi @sirpalmeirao, thanks for the contribution 😄 Can you please bump minor on Chart.yaml since this is a new feature? |
Hey @GMartinez-Sisti sure. Already made that change. 🙏 |
dnsPolicy added:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sirpalmeirao, the CI failed because helm-docs needs to be match the result of the check. We prefer to have specific values for keys so they are not comments. WDYT of this method? If the suggested logic does what I think it will, there will be no changes for existing deployments, unless dnsPolicy
is changed and dnsConfig
is populated.
Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
Regarding the method LGTM! 👍
unit tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sirpalmeirao
what
Adds dnsConfig property on Atlantis.
why
Allows dns resolution for specific domains.
tests
unit tests made successfully.
references