Get error from kubernetes response #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ltamaster What do you think about it? |
|
Hi @aliksend Sorry, I am busy this week, I will review it next week Thanks |
|
@ltamaster Thank you for response. Look when it will be convenient for you |
|
@ltamaster Will you be able to look at the weekend? |
This was referenced Nov 21, 2019
|
Please, can you make new release? |
|
done |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
Fail step when exit code != 0
Actual behavior
Step marked as OK even if exit code != 0
Solution
To check error, returned by kubernetes
Error checking code stealed from latest version of kubernetes-client/python-base:
https://github.com/kubernetes-client/python-base/blob/6b6546131217a2a9fdcf431a286c346619d2923a/stream/ws_client.py#L215
I'm not a python developer so code can be not perfect
May be it will be useful to add code like this in other connect_get_namespaced_pod_exec calls (like in run_command) but I not sure how to do it correctly