Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support formatting in lsp #576

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Support formatting in lsp #576

merged 2 commits into from
Jul 1, 2023

Conversation

ModProg
Copy link
Contributor

@ModProg ModProg commented Jun 30, 2023

No description provided.

@udoprog udoprog added the enhancement New feature or request label Jul 1, 2023
@udoprog udoprog changed the title support formatting in lsp Support formatting in lsp Jul 1, 2023
udoprog
udoprog reviewed Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@udoprog udoprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks mostly good, some nits and suggestions.

crates/rune/src/languageserver/state.rs Outdated Show resolved Hide resolved
crates/rune/src/languageserver/state.rs Outdated Show resolved Hide resolved
crates/rune/src/languageserver/state.rs Outdated Show resolved Hide resolved
crates/rune/src/languageserver/state.rs Outdated Show resolved Hide resolved
crates/rune/src/languageserver/state.rs Outdated Show resolved Hide resolved
@ModProg ModProg requested a review from udoprog July 1, 2023 08:45
@udoprog udoprog merged commit 0b6e4f7 into rune-rs:main Jul 1, 2023
@udoprog
Copy link
Collaborator

udoprog commented Jul 1, 2023

Much appreciated! Should be out in the next nightly.

@chenrui333 chenrui333 mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udoprog udoprog udoprog approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ModProg @udoprog