Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to avoid unsound use of references in registered functions. An issue that was discovered when investigating #600.
The way function arguments are currently modeled uses unbound references, which among other things allow you to register a
'static
reference or any associated lifetime allowing values to escape:With this change, functions like the above are correctly rejected instead. A downside is that we can no longer use references for arguments in async functions. Instead these must use owned types:
Becomes:
And associated types like this:
Becomes: