Adding unsigned smart support to ByteBuffer

runejs · Jan 26, 2021 · 5781707 · 5781707
1 parent aa9b4bc
commit 5781707
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@runejs/core",
-    "version": "1.0.1",
+    "version": "1.1.0",
     "description": "Core logging and networking functionality for RuneJS applications.",
     "main": "dist/index.js",
     "types": "dist/index.d.ts",

diff --git a/src/buffer/byte-buffer.ts b/src/buffer/byte-buffer.ts
@@ -52,7 +52,7 @@ export class ByteBuffer extends Uint8Array {
         const readerIndex = this._readerIndex;
 
         if(type === 'SMART') {
-            return this.getSmart(readerIndex);
+            return this.getSmart(readerIndex, signed);
         } else {
             let size = SIZES[type];
             let signedChar = signed === 'SIGNED' ? '' : 'U';
@@ -189,13 +189,13 @@ export class ByteBuffer extends Uint8Array {
         }
     }
 
-    private getSmart(offset: number): number {
+    private getSmart(offset: number, signed: Signedness = 'SIGNED'): number {
         const peek = this[offset];
 
         if(peek < 128) {
-            return this.get('BYTE', 'UNSIGNED');
+            return this.get('BYTE', 'UNSIGNED') - (signed === 'SIGNED' ? 0 : 64);
         } else {
-            return this.get('SHORT', 'UNSIGNED') - 32768;
+            return this.get('SHORT', 'UNSIGNED') - (signed === 'SIGNED' ? 32768 : 49152);
         }
     }