Skip to content

Commit

Permalink
Update web-component-analyzer dependency to fix ts5.x support (#305)
Browse files Browse the repository at this point in the history
* Get lit-analyzer passing in TS 5.0

* Update vscode settings for 100 column wrapping

This better matches the repo's current formatting

* Update wireit

* Actually fix the visit-dependencies bug with TS 5.0

* feat: update web-component-analyzer and typescript

typescript 5.x removed a few deprecated methods, one of which we
depended on inside WCA. That has since been fixed over in the WCA repo.

This change is to now bump our dependency of WCA so we pull the fix in.

Meanwhile, typescript has also been updated to match the same semver as
what WCA depends on (otherwise we get type mismatches when passing
`SourceFile` objects around).

* Run VSCode integration tests whenever we run the main tests.

* Update tested Node versions to currently LTS

* Drop back to node 18 for vscode, update actions

Drop old node versions for test

* Drop vscode node version to node 16 for windows

---------

Co-authored-by: Peter Burns <rictic@google.com>
  • Loading branch information
43081j and rictic authored Jun 14, 2023
1 parent 92c084d commit 2422d55
Show file tree
Hide file tree
Showing 13 changed files with 214 additions and 137 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/test_vscode.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: VSCode Integration Test
on: [push]
on:
pull_request:
push:
branches:
- master

jobs:
test:
Expand All @@ -9,9 +13,9 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Install Node.js
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: 16.x
- run: npm ci
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ jobs:
strategy:
matrix:
os: [windows-latest, ubuntu-latest]
node: [16, 17]
node: [18, 20]
exclude:
- os: windows-latest
node: "17"

steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}

Expand Down
8 changes: 7 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
{
"typescript.tsdk": "node_modules/typescript/lib"
"typescript.tsdk": "node_modules/typescript/lib",
"editor.wordWrapColumn": 100,
"editor.rulers": [
{
"column": 100
}
]
}
62 changes: 51 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@
"lint-staged": "^10.2.10",
"nodemon": "^2.0.4",
"prettier": "^2.4.1",
"typescript": "~4.4.3",
"wireit": "^0.1.1"
"typescript": "~4.4.4",
"wireit": "^0.9.5"
},
"husky": {
"hooks": {
Expand Down
Loading

0 comments on commit 2422d55

Please sign in to comment.