Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions to include latest node LTS. #221

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

rictic
Copy link
Collaborator

@rictic rictic commented Jan 14, 2022

No description provided.

@rictic rictic requested a review from justinfagnani January 14, 2022 17:38
Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 12 exits LTS in April, btw.

with:
name: vscode-lit-plugin
path: vscode-lit-plugin
path: vscode-lit-plugin # is this right? the actual path is packages/vscode-lit-plugin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some script that builds the plugin to a top-level folder. Documenting and simplifying the build system stuff should be one of the priorities.

@rictic rictic merged commit 5c99dff into master Jan 21, 2022
@rictic rictic deleted the update-github-actions branch January 21, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants