Move all bundling into vscode-lit-plugin #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way downstream users of ts-lit-plugin are free to bundle it with their preferred settings.
rictic
commented
Apr 19, 2022
| "files": [ | ||
| "src/**/*", | ||
| "esbuild.script.js" | ||
| "../ts-lit-plugin/src/**/*", | ||
| "../ts-lit-plugin/index.js", |
There was a problem hiding this comment.
@aomarks is this kosher, or should I put this script at the toplevel of the monorepo?
There was a problem hiding this comment.
Should be fine, input files can reach out of the package. It's only output files that currently can't.
aomarks
approved these changes
Apr 19, 2022
aomarks
approved these changes
Apr 19, 2022
justinfagnani
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way downstream users of ts-lit-plugin are free to bundle it with their preferred settings.