Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to emit index entries. #271

Merged
merged 18 commits into from
Oct 5, 2022

Conversation

bicknellr
Copy link
Contributor

@bicknellr bicknellr commented Sep 6, 2022

This is an updated version of #37.

rictic and others added 2 commits August 10, 2019 17:16
I'm prototyping a Kythe TypeScript indexer plugin and things are fitting together pretty well.

This starts by adding a method on the analyzer that will yield all of the information that the analyzer has determined about a file. I started with element and attribute references as they seem like the most valuable. What else could we emit here?
@bicknellr bicknellr changed the title Update "Add the ability to emit index entries." Add the ability to emit index entries. Sep 6, 2022
@bicknellr bicknellr marked this pull request as ready for review September 27, 2022 21:39
@bicknellr
Copy link
Contributor Author

cc @rictic

Copy link
Collaborator

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent test suite!

@bicknellr
Copy link
Contributor Author

I noticed there were a few places in the tests that used .js in the test file names when they should technically be .ts, so I updated those.

@bicknellr
Copy link
Contributor Author

Oh, I don't have merge permissions for this repo.

@bicknellr
Copy link
Contributor Author

I'm going to add a change log entry also.

@bicknellr
Copy link
Contributor Author

Added.

@rictic rictic merged commit d02f6d9 into runem:master Oct 5, 2022
@bicknellr bicknellr deleted the update-index-entries-pr branch October 28, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants