Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the any type to bind to security sensitive properties #276

Merged
merged 4 commits into from
Sep 15, 2022

Conversation

bicknellr
Copy link
Contributor

@bicknellr bicknellr commented Sep 14, 2022

From the CL description:

Note that this is not security sensitive code. The actual security boundary is at runtime. This is just the type checker assisting the developer, predicting what the runtime enforcement will allow/reject.

Allowing any here aligns with TypeScript's general type checking principles, where you're allowed to do just about anything you want with an any typed value.

This upstreams http://cl/354348347.

bicknellr and others added 3 commits September 14, 2022 16:20
Note that this is not security sensitive code. The actual security boundary is at runtime. This is just the type checker assisting the developer, predicting what the runtime
enforcement will allow/reject.

Allowing `any` here aligns with TypeScript's general type checking principles,
where you're allowed to do just about anything you want with an `any` typed value.

Co-authored-by: Peter Burns <rictic@google.com>
@bicknellr bicknellr marked this pull request as ready for review September 14, 2022 23:29
@bicknellr bicknellr requested a review from rictic September 15, 2022 00:02
@rictic rictic merged commit 315252f into runem:master Sep 15, 2022
@bicknellr bicknellr deleted the trusted-types-any branch September 15, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants