Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TypeScript 5.0 #303

Closed
wants to merge 6 commits into from

Conversation

bicknellr
Copy link
Contributor

  • Installs TypeScript 5.0 as a dev dependency and adds it to the list of versions that are tested.
  • Updates web-component-analyzer to 1.1.7, which added support for TypeScript 5.0.
  • Fixes a few dependencies that no longer work and works around a TS compiler API deprecation.

…d install scripts.

The install scripts for the previous version attempt to fetch a URL that now
consistently 404's. However, this dependency is only needed for a couple of
files that are checked directly into the repo, so there's no need to actually
build the package. The commit that was used before isn't available as a release
on GitHub but the latest version has the same files at the same location (with
seemingly minor updates), so I've also started referencing the latest version.

FWIW, `vscode-styled-components` is still not available as an npm package.
@bicknellr bicknellr marked this pull request as ready for review April 12, 2023 19:06
@bicknellr
Copy link
Contributor Author

cc @rictic, here's what I have so far. The tests pass but it breaks while trying to package the plugin, which I haven't looked into at all.

@rictic
Copy link
Collaborator

rictic commented Jun 14, 2023

Superceded by #305

@rictic rictic closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants