-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CSS and HTML Language Service versions #352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you!
It looks like the TypeScript type incompat issue is breaking on CI. Updating TypeScript is good to do to ensure that we're compatible across all different versions, but unless we find and fix an incompatibility it actually doesn't impact the user because we use the locally installed version of TypeScript in the user's code. IMO let's do the TS update as a separate change, because to keep the build green it needs to be coordinated across a couple repos |
Yea, I didn’t see anything in the tests locally, but it’s just the last commit. Very easy to rollback. I’ll do it when I get on my computer later. |
Okay, @rictic I rolled back the TypeScript change. We should be good to go now! |
Looking forward to this, any idea when it will be released? |
@runem Sorry for the ping, but is a release scheduled for this. Latest Stylelint standard ruleset expects some of these new css features which causes them to show up as errors in the IDE |
This is a pretty simple PR. I updated the CSS and HTML Language Service packages to their latest release. The current locked versions are from mid 2020, and there have been many new features like the
accent-color
CSS attribute that prompted this work.This fixes #314, most likely #146, potentially #326, #132, #284, and #259 (but I haven't tested it).
I also updated the TypeScript version to 5.3.3, and added the appropriate compatibility checks to the test suite for 5.2 and 5.3.