Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable finch support-bundle generate to execute on Windows whe… #976

Merged
merged 1 commit into from
Jun 20, 2024

Commits on Jun 12, 2024

  1. fix: Enable finch support-bundle generate to execute on Windows whe…

    …re the `uname` command does not exist
    
    On Windows environments where the `uname` command is not available,
    executing `finch support-bundle generate` results in the following error:
    
    ```
    C:\Users\simpl>"..\..\Program Files\Finch\bin\finch.exe" support-bundle generate
    time="2024-06-11T23:21:16+09:00" level=info msg="Generating support bundle..."
    time="2024-06-11T23:21:16+09:00" level=fatal msg="exec: \"uname\": executable file not found in %PATH%"
    ```
    
    This bug has been reported in the following issue:
    
    - runfinch#897
    
    Therefore, this fix enables the execution of
    `finch support-bundle generate` even when the `uname` command is not
    available on Windows.
    
    Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
    haytok committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    ccd4d56 View commit details
    Browse the repository at this point in the history