Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update snapshotters reference #986

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: update snapshotters reference #986

merged 1 commit into from
Jun 21, 2024

Conversation

emmanuel-ferdman
Copy link
Contributor

Issue #, if available:

Description of changes:

PR #563 moved the location of the snapshotters.md file. This PR adjusts sources to changes.

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@austinvazquez austinvazquez added the documentation Improvements or additions to documentation label Jun 19, 2024
@austinvazquez
Copy link
Member

Thanks for making the contribution! Changes LGTM. GitHub UI seems to be stuck waiting on CI checks which have already completed. Closing and reopening to see if that will unstick.

@austinvazquez austinvazquez reopened this Jun 19, 2024
pendo324 pushed a commit that referenced this pull request Jun 21, 2024
Issue #, if available:
#986 is currently blocked on merge due to required CI job checks not
matching the expected naming in the branch protection ruleset. The
`go-linter` job was renamed in #649 to `lint` and `unit-test` and
`gen-code-no-diff` were expanded for the Windows platform.

*Description of changes:*
This change updates the docs CI job to match the expected job names in
the branch protection ruleset.

*Testing done:*
Manually verified the branch protection ruleset name matches.

- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@pendo324
Copy link
Member

Closing / reopening to try to unstuck CI now that #988 is merged

@pendo324 pendo324 closed this Jun 21, 2024
@pendo324 pendo324 reopened this Jun 21, 2024
@pendo324 pendo324 merged commit 06b9027 into runfinch:main Jun 21, 2024
57 checks passed
@pendo324
Copy link
Member

Merged, thanks!

austinvazquez pushed a commit that referenced this pull request Jul 2, 2024
🤖 I have created a release *beep* *boop*
---


## [1.2.1](v1.2.0...v1.2.1)
(2024-07-02)


### Build System or External Dependencies

* **deps:** Bump github.com/aws/aws-sdk-go-v2 from 1.27.0 to 1.27.1
([#963](#963))
([4c2dc12](4c2dc12))
* **deps:** Bump github.com/aws/aws-sdk-go-v2 from 1.27.1 to 1.27.2
([#974](#974))
([54aa67c](54aa67c))
* **deps:** bump github.com/aws/aws-sdk-go-v2 from 1.27.2 to 1.30.0
([#991](#991))
([bbcb8e7](bbcb8e7))
* **deps:** Bump github.com/docker/cli from 26.1.3+incompatible to
26.1.4+incompatible
([#973](#973))
([f774e2d](f774e2d))
* **deps:** bump github.com/docker/cli from 26.1.4+incompatible to
27.0.2+incompatible
([#999](#999))
([0244698](0244698))
* **deps:** bump github.com/docker/cli from 27.0.2+incompatible to
27.0.3+incompatible
([#1005](#1005))
([c801e69](c801e69))
* **deps:** Bump github.com/docker/docker from 26.1.3+incompatible to
26.1.4+incompatible
([#972](#972))
([05b9c05](05b9c05))
* **deps:** bump github.com/docker/docker from 26.1.4+incompatible to
27.0.1+incompatible
([#996](#996))
([1f68260](1f68260))
* **deps:** bump github.com/docker/docker from 27.0.1+incompatible to
27.0.2+incompatible
([#1001](#1001))
([50a639b](50a639b))
* **deps:** bump github.com/docker/docker from 27.0.2+incompatible to
27.0.3+incompatible
([#1006](#1006))
([537abad](537abad))
* **deps:** bump github.com/spf13/cobra from 1.8.0 to 1.8.1
([#983](#983))
([7b2bed6](7b2bed6))
* **deps:** bump golang.org/x/image from 0.12.0 to 0.18.0
([#998](#998))
([398658e](398658e))
* **deps:** Bump golang.org/x/text from 0.15.0 to 0.16.0
([#964](#964))
([8a3973a](8a3973a))
* **deps:** Bump golang.org/x/tools from 0.21.0 to 0.22.0
([#967](#967))
([3921b00](3921b00))
* **deps:** bump k8s.io/apimachinery from 0.30.1 to 0.30.2
([#981](#981))
([c8ebf20](c8ebf20))
* **deps:** Bump submodules and dependencies
([#1008](#1008))
([6134a5a](6134a5a))
* **deps:** Bump submodules and dependencies
([#949](#949))
([b5ee424](b5ee424))


### Bug Fixes

* add SOCI snapshotter hash check
([#985](#985))
([563f346](563f346))
* Allow to use the COMPOSE_FILE variable in finch compose
([#994](#994))
([17d4bc8](17d4bc8))
* Enable `finch support-bundle generate` to execute on Windows whe…
([#976](#976))
([9c1caf0](9c1caf0))
* update snapshotters reference
([#986](#986))
([06b9027](06b9027))
* verify shasum for finch dependencies
([#969](#969))
([9d85f25](9d85f25))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants