Draft: Fix grad_accumulation in transformers #827

franz101 · 2024-01-23T19:47:13Z

Please do not create a pull request without creating an issue first.

Changes need to be discussed before proceeding, pull requests submitted without linked issues may be rejected.

Please provide enough information so that others can review your pull request. You can skip this if you're fixing a typo – it happens.

I have added tests to tests to cover my changes.
I have updated docs/, if necessary.
I have updated the README.md, if necessary.

What existing issue does this pull request close?

Put closes #issue-number in this pull request's description to auto-close the issue that this fixes.

How are these changes tested?

This pull request includes automated tests for the code it touches and those tests are described below. If no tests are included, reasons why must be provided below.

These changes are tested with [...]

Demonstration

Demonstrate your contribution.

For example, what are the exact commands you ran and their output, related screenshots, screen-recordings, test runs, anything that can showcase.

Provide additional context.

Provide as much relevant context as you like.

codecov-commenter · 2024-01-23T19:56:18Z

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.53%. Comparing base (85109ae) to head (636d439).
Report is 42 commits behind head on main.

Files	Patch %	Lines
dataquality/integrations/transformers_trainer.py	35.71%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
+ Coverage   86.47%   86.53%   +0.06%     
==========================================
  Files         194      194              
  Lines       15739    15745       +6     
==========================================
+ Hits        13610    13625      +15     
+ Misses       2129     2120       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-03-05T01:43:29Z