fix github link, support disabling tooltips' clickToPin

runsascoded · Dec 27, 2021 · f017b36 · f017b36
1 parent 706acd1
commit f017b36
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/github-link.tsx b/src/github-link.tsx
@@ -16,7 +16,7 @@ export const GithubImg = styled.img`
 
 export function GithubIssuesLink({ Tooltip, }: { Tooltip: FC<Props> }) {
     return (
-        <Tooltip id={"github-header"} css={center} arrow placement="bottom" title="See this project's open issues on GitHub">
+        <Tooltip id={"github-header"} css={center} clickToPin={false} arrow placement="bottom" title="See this project's open issues on GitHub">
             <GithubLink href={issuesUrl}>
                 <GithubImg src={`data:image/png;base64,${githubLogo}`}/>
             </GithubLink>

diff --git a/src/tooltip.tsx b/src/tooltip.tsx
@@ -18,7 +18,7 @@ export type LiftedState = {
     setClicked: Setter<boolean>
 }
 export type CSS = { [k: string]: { [k: string]: string | number | undefined } }
-export type Props = mui.TooltipProps & { id: string, css?: CSS }
+export type Props = mui.TooltipProps & { id: string, css?: CSS, clickToPin?: boolean }
 export type OuterProps = Props & MakeTooltipProps
 export type InnerProps = OuterProps & LiftedState
 
@@ -34,7 +34,7 @@ export const OuterTooltip = (props: OuterProps) => {
 export const InnerTooltip = mui.styled(
     ({
          className, arrow, children, title,
-         id, openTooltipId, handleOpen, handleClose,
+         id, clickToPin, openTooltipId, handleOpen, handleClose,
          clicked, setClicked,
          ...props
     }: InnerProps) => {
@@ -66,6 +66,7 @@ export const InnerTooltip = mui.styled(
             }
         }
         const handleTooltipClick = (e: any) => {
+            if (clickToPin === false) return  // default to true
             e.stopPropagation()
             e.preventDefault()
             // console.log("Tooltip: body click:", id)
@@ -88,7 +89,6 @@ export const InnerTooltip = mui.styled(
                 <mui.Tooltip
                     key={"mui.Tooltip"}
                     onClick={handleTooltipClick}
-                    onMouseOver={handleTooltipOpen}
                     onOpen={handleTooltipOpen}
                     onClose={handleTooltipClose}
                     open={open || clicked}