Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid axioms generated (asserting \bottom{S} unconditionally) #3268

Closed
jberthold opened this issue Mar 23, 2023 · 3 comments · Fixed by #3288
Closed

Invalid axioms generated (asserting \bottom{S} unconditionally) #3268

jberthold opened this issue Mar 23, 2023 · 3 comments · Fixed by #3288
Assignees

Comments

@jberthold
Copy link
Member

The K-compiler currently generates invalid axioms like axiom{} \bottom{S}() [constructor{}()] // no junk (for S in SortSet, SortMap, SortList, and SortK).
These axioms state that \bottom is \top and could be used to prove anything we want (the Haskell back-end skips these invalid axioms at the moment).

To reproduce:

$ echo "module TEST endmodule" > test.k
$ kompile test.k
$ grep -e "axiom.. .bottom" test-kompiled/definition.kore
  axiom{} \bottom{SortList{}}() [constructor{}()] // no junk
  axiom{} \bottom{SortK{}}() [constructor{}()] // no junk
  axiom{} \bottom{SortMap{}}() [constructor{}()] // no junk
  axiom{} \bottom{SortSet{}}() [constructor{}()] // no junk
@ehildenb
Copy link
Member

@Robertorosmaninho
Copy link
Collaborator

Hey @jberthold, the expected behavior doesn't have any axioms in this case, right? E.g., delete these lines that have axioms for empty collections.

@jberthold
Copy link
Member Author

Correct, these axioms should just not be there.

Baltoli pushed a commit that referenced this issue Nov 1, 2023
* init version of kup

* install script

* fix flake

* fix install

* add back k-framework cache

* Update dependency: haskell-backend/src/main/native/haskell-backend (#2897)

* haskell-backend/src/main/native/haskell-backend: 5b558293c - 3214 support not simplification rules (#3234)

* haskell-backend/src/main/native/haskell-backend: 6e5d07163 - Disable automatic run of update job (#3258)

* haskell-backend/src/main/native/haskell-backend: ebd986060 - Update dependency: deps/k_release (#3233)

* Set Version: 5.4.2

* haskell-backend/src/main/native/haskell-backend: 4a437a812 - Handle incorrect log path for `--bug-report` option (#3269)

* haskell-backend/src/main/native/haskell-backend: f9366b6f8 - Nix profiling tweaks (#3268)

* haskell-backend/src/main/native/haskell-backend: 9ea642db3 - Feature/profiling performance workflow (#3265)

* haskell-backend/src/main/native/haskell-backend: 0c75536f4 - Rewrite script which generates regressions tests (#3261)

* haskell-backend/src/main/native/haskell-backend: 8844d5c2b - Add functional-spec test from KEVM (#3271)

* haskell-backend/src/main/native/haskell-backend: a5653fa8d - use state to cache simplifier across branches during unification (#3270)

* Hardcode flake.lock as a workaround to broken CI

* Set Version: 5.4.3

* haskell-backend/src/main/native/haskell-backend: 0a2b03245 - Add C semantics smoke test depth 100 (#3274)

* Set Version: 5.4.4

* haskell-backend/src/main/native/haskell-backend: 23530bd9a - 3223 json rpc cut points and terminal rules (#3273)

* Set Version: 5.4.5

* Fix

* Set Version: 5.4.6

* Set Version: 5.4.7

* haskell-backend/src/main/native/haskell-backend: 087544025 - Modify Ceil simplifier to not recurse (#3209)

* haskell-backend/src/main/native/haskell-backend: b68c43a93 - Hotfix/profiling workflow triggers (#3272)

* Set Version: 5.4.8

* haskell-backend/src/main/native/haskell-backend: 3c3f31bf2 - Update dependency: deps/k_release (#3275)

* haskell-backend/src/main/native/haskell-backend: 133a83eae - Using action runner permissions token for gh tool (#3277)

* Hardcode flake diff changes

Co-authored-by: devops <devops@runtimeverification.com>
Co-authored-by: ana-pantilie <ana.pantilie95@gmail.com>
Co-authored-by: Ana Pantilie <45069775+ana-pantilie@users.noreply.github.com>

* cleanup

* remove ksummarize for now

* Set Version: 5.4.9

* revert install-k

* Set Version: 5.4.9

* revert install-k

* Set Version: 5.4.9

* fix

* once in master, we should always download the latest version of kup

* moved kup to root and fixed formatting/lint issues

* updated flake

Co-authored-by: rv-jenkins <admin@runtimeverification.com>
Co-authored-by: devops <devops@runtimeverification.com>
Co-authored-by: ana-pantilie <ana.pantilie95@gmail.com>
Co-authored-by: Ana Pantilie <45069775+ana-pantilie@users.noreply.github.com>
Baltoli pushed a commit that referenced this issue Nov 1, 2023
…2918)

* Update dependency: haskell-backend/src/main/native/haskell-backend (#2897)

* haskell-backend/src/main/native/haskell-backend: 5b558293c - 3214 support not simplification rules (#3234)

* haskell-backend/src/main/native/haskell-backend: 6e5d07163 - Disable automatic run of update job (#3258)

* haskell-backend/src/main/native/haskell-backend: ebd986060 - Update dependency: deps/k_release (#3233)

* Set Version: 5.4.2

* haskell-backend/src/main/native/haskell-backend: 4a437a812 - Handle incorrect log path for `--bug-report` option (#3269)

* haskell-backend/src/main/native/haskell-backend: f9366b6f8 - Nix profiling tweaks (#3268)

* haskell-backend/src/main/native/haskell-backend: 9ea642db3 - Feature/profiling performance workflow (#3265)

* haskell-backend/src/main/native/haskell-backend: 0c75536f4 - Rewrite script which generates regressions tests (#3261)

* haskell-backend/src/main/native/haskell-backend: 8844d5c2b - Add functional-spec test from KEVM (#3271)

* haskell-backend/src/main/native/haskell-backend: a5653fa8d - use state to cache simplifier across branches during unification (#3270)

* Hardcode flake.lock as a workaround to broken CI

* Set Version: 5.4.3

* haskell-backend/src/main/native/haskell-backend: 0a2b03245 - Add C semantics smoke test depth 100 (#3274)

* Set Version: 5.4.4

* haskell-backend/src/main/native/haskell-backend: 23530bd9a - 3223 json rpc cut points and terminal rules (#3273)

* Set Version: 5.4.5

* Fix

* Set Version: 5.4.6

* Set Version: 5.4.7

* haskell-backend/src/main/native/haskell-backend: 087544025 - Modify Ceil simplifier to not recurse (#3209)

* haskell-backend/src/main/native/haskell-backend: b68c43a93 - Hotfix/profiling workflow triggers (#3272)

* Set Version: 5.4.8

* haskell-backend/src/main/native/haskell-backend: 3c3f31bf2 - Update dependency: deps/k_release (#3275)

* haskell-backend/src/main/native/haskell-backend: 133a83eae - Using action runner permissions token for gh tool (#3277)

* Hardcode flake diff changes

Co-authored-by: devops <devops@runtimeverification.com>
Co-authored-by: ana-pantilie <ana.pantilie95@gmail.com>
Co-authored-by: Ana Pantilie <45069775+ana-pantilie@users.noreply.github.com>

* haskell-backend/src/main/native/haskell-backend: ba227c0dc - Update dependency: deps/k_release (#3276)

* Set Version: 5.4.9

* Set Version 5.4.8

* Set Version: 5.4.9

* Set Version: 5.4.10

* Set Version: 5.4.11

* Set Version: 5.4.12

* Set Version: 5.4.13

* haskell-backend/src/main/native/haskell-backend: 24e8a3d48 - Update dependency: deps/k_release (#3282)

* Update flake.lock

Co-authored-by: devops <devops@runtimeverification.com>
Co-authored-by: ana-pantilie <ana.pantilie95@gmail.com>
Co-authored-by: Ana Pantilie <45069775+ana-pantilie@users.noreply.github.com>
Co-authored-by: Everett Hildenbrandt <everett.hildenbrandt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants