-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update simple to llvm backend #3181
Conversation
..._languages/1_simple/2_typed/2_dynamic/exercises/typed-exceptions/tests/div-nondet.simple.out
Show resolved
Hide resolved
...uages/1_simple/2_typed/2_dynamic/exercises/functions-with-throws/tests/div-nondet.simple.out
Show resolved
Hide resolved
@ehildenb The missing result is due to the fact that the llvm and Haskell backends are currently unable to heat one operand of a symbol, then partially evaluate it, then cool it, then heat another argument, evaluate it to a result, cool it, and then heat the first operand again and fully evaluate it. This is a known issue with the nondeterminism of strictness that we have decided to ignore for the time being. The same issue has led to missing results in several other tests where those definitions have already been modified and those search results removed. I've already spoken to Grigore about this issue and the consensus is that we should not block the migration of the tutorial off of the java backend on this particular issue. |
Sounds good, is this documented in an issue with a minimal example somewhere? |
It is not. I'll create an issue tomorrow since I'm done coding for the day. I'll link it here and then I'll let you re review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Here is the issue I created: #3185 It has a minimal example. |
Updates simple-typed-static and simple-typed-dynamic to use the llvm backend. Requires corresponding updates to the exercises.