Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple to llvm backend #3181

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Update simple to llvm backend #3181

merged 5 commits into from
Feb 23, 2023

Conversation

dwightguth
Copy link
Collaborator

Updates simple-typed-static and simple-typed-dynamic to use the llvm backend. Requires corresponding updates to the exercises.

@rv-jenkins rv-jenkins changed the base branch from master to develop February 22, 2023 19:23
@dwightguth dwightguth marked this pull request as ready for review February 22, 2023 22:20
@dwightguth dwightguth requested a review from a team as a code owner February 22, 2023 22:20
@dwightguth
Copy link
Collaborator Author

@ehildenb The missing result is due to the fact that the llvm and Haskell backends are currently unable to heat one operand of a symbol, then partially evaluate it, then cool it, then heat another argument, evaluate it to a result, cool it, and then heat the first operand again and fully evaluate it. This is a known issue with the nondeterminism of strictness that we have decided to ignore for the time being. The same issue has led to missing results in several other tests where those definitions have already been modified and those search results removed. I've already spoken to Grigore about this issue and the consensus is that we should not block the migration of the tutorial off of the java backend on this particular issue.

@ehildenb
Copy link
Member

Sounds good, is this documented in an issue with a minimal example somewhere?

@dwightguth
Copy link
Collaborator Author

It is not. I'll create an issue tomorrow since I'm done coding for the day. I'll link it here and then I'll let you re review

Copy link
Contributor

@radumereuta radumereuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dwightguth
Copy link
Collaborator Author

Here is the issue I created: #3185 It has a minimal example.

@rv-jenkins rv-jenkins merged commit 093844b into develop Feb 23, 2023
@rv-jenkins rv-jenkins deleted the simple2 branch February 23, 2023 19:23
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants