Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to java backend from main regression test suite #3244

Merged
merged 31 commits into from
Mar 17, 2023

Conversation

dwightguth
Copy link
Collaborator

Here we remove all calls to the Java backend from the main test suite in preparation for deletion of the backend itself.

Tests were converted to the llvm or haskell backend from the Java backend, run, and then gradually refined until it was either clear the test relied on behavior of the Java backend that couldn't easily be replicated, in which case we deleted the test, or until the test behaved in a sensible fashion, at which point test output files were updated as needed.

We also remove references to a couple different command line flags which will be deleted when the Java backend is removed.

@rv-jenkins rv-jenkins changed the base branch from master to develop March 16, 2023 21:10
@dwightguth dwightguth marked this pull request as ready for review March 16, 2023 22:42
Copy link
Contributor

@radumereuta radumereuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.
But there are still a few warnings printed by the haskell backend for missing no-evaluators.
We should try to keep the output clean so it's easier to spot where something fails.

@dwightguth
Copy link
Collaborator Author

There was one remaining test left that still had warnings about functions without evaluators. I fixed it. Please re-review.

Copy link
Contributor

@radumereuta radumereuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few warnings thrown from the haskell backend through kprove-legacy, but they are small. We may want to tackle those with another update to remove kprove-legacy.

@dwightguth
Copy link
Collaborator Author

I agree that should be a separate pr.

@dwightguth dwightguth enabled auto-merge (squash) March 17, 2023 20:39
@dwightguth dwightguth merged commit 4b52854 into develop Mar 17, 2023
@dwightguth dwightguth deleted the regression branch March 17, 2023 22:36
@radumereuta radumereuta linked an issue Mar 30, 2023 that may be closed by this pull request
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all tests using Java backend from repo
3 participants