Make new-format rules without antileft the default #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwightguth
approved these changes
May 4, 2023
There was a problem hiding this comment.
Given that we are going to need the antileft patterns in order to do proof object generation, which we are already starting to dig into, I would not say that the enable flag ought to be deprecated. We're going to want to keep it around. Code looks good otherwise though.
|
From the original issue:
Obviously happy to remove the deprecation and keep the old behaviour, I just wanted to make sure everyone is on the same page here. We can discuss in the K meeting. |
5 tasks
Baltoli
pushed a commit
that referenced
this pull request
Nov 1, 2023
…3073) * haskell-backend/src/main/native/haskell-backend: acb353d48 - Update dependency: deps/k_release (#3391) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: 549ee9057 - pin CI to ubuntu-20.04 (#3401) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: a45daae7e - Presort pairWiseElemsOfSameType argument (#3396) * Sync flake inputs to submodules Co-authored-by: rv-jenkins <devops@runtimeverification.com> Co-authored-by: Ana Pantilie <45069775+ana-pantilie@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #3035
This PR inverts the previous behaviour of ModuleToKore such that the new-format rewrite rules are generated by default, rather than being gated behind the
--disable-kore-antileftflag.Changes in this PR:
--disable-kore-antileftto produce--enable-kore-antileftThis PR's CI run will demonstrate that the new changes allow the full regression test suite to run. I have also completed downstream testing with the following semantics via their Nix flakes, and can add more to this list if required:
If this change causes unexpected failures, we can address it in one of two ways depending on the failure:
--enable-kore-antileftflag to a semantics' build system, and fix gradually