delete mounting of host's user and group info #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F-WRunTime
approved these changes
Jul 11, 2023
ehildenb
approved these changes
Jul 11, 2023
Baltoli
pushed a commit
that referenced
this pull request
Nov 1, 2023
…3146) * haskell-backend/src/main/native/haskell-backend: 1ec3533ff - Remove eventlog2threadscope dependency (#3491) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: 410c1b6c6 - [#3410] Validate debug options (#3465) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: 567b909f1 - Fix output of check implication (version 2) (#3492) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: b74e9f8d5 - RPC server: add `add-module` endpoint (#3490) * Sync flake inputs to submodules * flake.nix: remove kore-prof * .github/workflows/update-deps: also run nix flake update --------- Co-authored-by: rv-jenkins <devops@runtimeverification.com> Co-authored-by: Everett Hildenbrandt <everett.hildenbrandt@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We appear to be having problems deploying maven packages because when we create the docker image to do so, its notion of where the home directory is seems to be wrong. I believe this is occurring because we are mounting /etc/passwd and /etc/group inside the guest to those files on the host. The reason this causes problems is that /etc/passwd contains the definition of where each user's home directory is, and due to the nature of ephemeral runners, we are configuring the host to have a dynamic home directory so that each instance of the runner doesn't conflict with one another.
I am pretty sure this type of mounting is not actually necessary since we already set the uid and gid of the docker user to be equal to the uid and gid of the same user and group on the host. However, we need to test to make sure nothing breaks before merging this.