Remove the option to opt out of the attribute whitelist #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scott-Guest
requested review from
radumereuta and
dwightguth
and removed request for
radumereuta
radumereuta
approved these changes
Jul 11, 2023
8 tasks
Baltoli
pushed a commit
that referenced
this pull request
Nov 1, 2023
…3154) * haskell-backend/src/main/native/haskell-backend: 2b96e26eb - Add `injective` to prelude constructors (#3494) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: 4e61206c5 - [#3462] Keep original names in SMT transcript (#3498) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: 42cd7c42f - Fix check-implication output 3 (#3497) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: 477c5d132 - Update kore design documentation (#3499) * Sync flake inputs to submodules --------- Co-authored-by: rv-jenkins <devops@runtimeverification.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2625
This PR removes the option
--no-pedantic-attributesto opt-out of the attribute whitelist. All attributes now must be known built-ins, and user-defined attributes can only be provided viagroup(_).To make this change, I also had to
CheckAtt.javaby sorting the attributestoStringin a few places missed by Emit user-defined groups as group(_) #3441 so that files output with-Eactually pass the whitelist