Fix release build #3512
Merged
Fix release build #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
requested review from
dwightguth,
radumereuta,
tothtamas28 and
goodlyrottenapple
jberthold
approved these changes
Jul 12, 2023
radumereuta
reviewed
Jul 12, 2023
| Note that on Ubuntu Focal, the default Maven version is not compatible with | ||
| newer versions of the JDK; for K's Maven build to work, please ensure you | ||
| have version 11 installed. | ||
|
|
There was a problem hiding this comment.
11-17 are fine to use. v18 is breaking the nailgun server.
There was a problem hiding this comment.
17 breaks maven 3.7, which is shipped only on Focal - it's a separate issue to Nailgun
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues with the release build:
pom.xml.I've tested the fixes by running them in the PR environment, then rebasing out. As best as I can tell without running the full release build, the issues are fixed.