Rule label cannot contain ` or whitespace #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwightguth
requested review from
radumereuta,
Scott-Guest and
Robertorosmaninho
radumereuta
reviewed
Aug 28, 2023
| checkLabel(sentence); | ||
| } | ||
|
|
||
| private static final Pattern whitespace = Pattern.compile("\\s"); |
There was a problem hiding this comment.
Why didn't you include the backtick here?
You have to traverse the label twice now.
There was a problem hiding this comment.
it's still linear time, the string is unlikely to be long, and I doubt the impact on performance will be substantial. We can always address this later if need be. I suspect the amdahl's law on this will be pretty minimal though.
5 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to the compiler that reports an error if a sentence label contains the backtick character or whitespace. This ought to allow the Maude backend to compile rule labels directly to Maude identifiers without some clumsy encoding system.
I am reasonably certain that it should not break anything to add this restriction.