Adding Profiling Tests CI to release workflow to create a baseline for master performance #3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for master performance
Robertorosmaninho
requested review from
dwightguth,
radumereuta and
F-WRunTime
rv-jenkins
pushed a commit
that referenced
this pull request
Sep 13, 2023
…nce on Bencher (#3627) This modification is necessary to create a baseline for newer branches to compare the performance of their changes against what we already have in develop. This modification is necessary to create and populate the develop's branch as the baseline for newer branches. This script `post_results_to_develop.py` works by getting the last benchmarks reports of the last branch merged into develop, aggregating them in one file, and posting them on the develop branch of Bencher. Hopefully, this is a temporary fix, as this was already accepted as a bug/possible feature by Bencher's maintainer bencherdev/bencher#187. This PR, unlike #3625, doesn't need to rerun all `Performance Tests` on the develop or master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification is necessary to create a baseline for newer branches to compare the performance of their changes against what we already have on master.
This modification sets the master's branch as the baseline and implements the tests in the release workflow because it already builds the K package. To make it in the develop's branch, a new workflow would be necessary to either build K from source or create and install the package.
Hopefully, this is a temporary fix, as I'm already working on a script to populate develop without re-running the Tests, and this was already accepted as a bug/possible feature by Bencher's maintainer here. I'll implement whatever solution becomes usable first so we can stop running these tests on every release.
Both solutions involve post the last result of a PR merged into the develop branch on Bencher's db. Once this is ready, the PR will get the baseline from develop instead of master.