Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 📝 Added section 2 docs #3639

Merged
merged 3 commits into from
Sep 15, 2023
Merged

docs: 📝 Added section 2 docs #3639

merged 3 commits into from
Sep 15, 2023

Conversation

KcatMa
Copy link
Contributor

@KcatMa KcatMa commented Sep 14, 2023

Fixed #3410

@KcatMa KcatMa requested a review from yiyi-wang-rv September 14, 2023 06:46
@KcatMa KcatMa self-assigned this Sep 14, 2023
@KcatMa KcatMa changed the base branch from master to develop September 14, 2023 06:46
@yiyi-wang-rv
Copy link
Contributor

Please deploy the website somewhere so we can see it. And why do you delete the back quotes in the doc?

@KcatMa
Copy link
Contributor Author

KcatMa commented Sep 15, 2023

Please deploy the website somewhere so we can see it. And why do you delete the back quotes in the doc?

OK! I have deployed it at https://kcatma.github.io/k.

I'm not sure if I should use the back-quote there because there is no use case in the entire toc.md now.

@yiyi-wang-rv
Copy link
Contributor

Hi @radumereuta . Could you please help review @KcatMa 's PR for the issue: #3410
We see that there is not that much content in section 2 yet.
Thank you!

Copy link
Contributor

@radumereuta radumereuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good.
Section 2 is still in progress. If we expose it to the public and we get complaints, then maybe we'll have more motivation to continue writing lessons.

@rv-jenkins rv-jenkins merged commit 0def35d into develop Sep 15, 2023
@rv-jenkins rv-jenkins deleted the section-2 branch September 15, 2023 11:02
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Section 2 of K Tutorial
4 participants