Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to new release.nix upload action #3696

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Oct 9, 2023

GitHub have deprecated the hub tool (https://github.com/runtimeverification/devops/issues/167), which we use via the upload-release.nix action to attach that Nix file to published K releases. As part of this deprecation, the K release was broken by hub being removed from the default public runner.

This PR (and associated changes) attempts to fix the issue by:

  • Forking the action from Tom Tuegel's repo to the RV namespace; given we rely on this code and are the only consumers of it we should probably have it located as such.
  • Amending the upload script to use gh:
    • The environment variable for the GitHub auth token is different between the two tools.
    • They have slightly different syntax at the command line, but from the documentation appear to be broadly compatible in terms of filenames, tags etc.
  • Versioning a new release of the action under the RV org.
  • Pointing the K release job at that version.

This process is difficult to test outside of the context of an actual K release going through, and so I propose to merge this PR and babysit the resulting release job to see what happens. If it does not work, we can revert to Tom's action easily and will be no worse off than we were initially.

Our fork of the release action is here: https://github.com/runtimeverification/upload-release.nix; the changes relevant to this PR are in commit 0b1594f

@Baltoli Baltoli requested a review from a team as a code owner October 9, 2023 13:03
@rv-jenkins rv-jenkins merged commit 66da7c4 into develop Oct 9, 2023
@rv-jenkins rv-jenkins deleted the fix-nix-release branch October 9, 2023 15:25
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants