Remove EAsSet[E] and WAsSet[W] traits in Transformers.scala to address IntelliJ error
#3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
approved these changes
Dec 4, 2023
radumereuta
approved these changes
Dec 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
EAsSet[E]andWAsSet[W]traits inTransformers.scala, and instead just duplicates a few lines of code betweenSetsGeneralTransformerandSetsTransformerWithErrors.As a result, we fix an annoying issue where IntelliJ incorrectly reports an error on every inheritor of these classes, falsely claiming that
errorUnit()has an incorrect return type.Given that the cost here is low, and similar issues have bitten us in the past by blocking use of the debugger (#3816), I think this is a worthwhile change. If no one is opposed, I plan to address any similar incorrectly-reported IntelliJ errors as I encounter them.