Add support for batch requests to JSON RPC server #4688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rv-jenkins
requested review from
ehildenb,
rv-jenkins,
F-WRunTime and
tothtamas28
as code owners
RaoulSchaffranek
force-pushed
the
raoul/rpc-batch-requests
branch
from
2b65e76 to
48b7d60
Compare
RaoulSchaffranek
force-pushed
the
raoul/rpc-batch-requests
branch
from
d1ff2a0 to
70f1a68
Compare
tothtamas28
reviewed
Nov 21, 2024
|
Thanks for the review @tothtamas28! Sounds all reasonable to me and I addressed your comments in f8fa54f |
tothtamas28
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simbolik and kontrol-node exchange many requests, and processing them one request at a time quickly becomes a performance bottleneck. By batching requests together we can avoid the bottleneck. The batching implementation here is part of the JSON RPC spec, see: https://www.jsonrpc.org/specification#batch