Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Add support for latest foundry version #399

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

anvacaru
Copy link
Contributor

@anvacaru anvacaru commented Feb 28, 2024

With the latest version, foundry does not include the ast field anymore in the generated contract a artifacts by default (source).
This change makes kontrol build to fail because we look for the ast fields to read Natspec comments.

In this PR :

  • add the ast = true config variable in the foundry.toml file to add the ast field
  • add a descriptive error message if the field is not present.

Later, we can automatically add the --ast flag to the internal 'forge build' command. A version check would be needed, as this flag is not backwards compatible.

@anvacaru anvacaru added the bug Something isn't working label Feb 28, 2024
@anvacaru anvacaru self-assigned this Feb 28, 2024
@rv-jenkins rv-jenkins merged commit 72d7a36 into master Feb 28, 2024
11 checks passed
@rv-jenkins rv-jenkins deleted the forge-ast branch February 28, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants