-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make booster the default #75
Conversation
Before we disable the booster tests, there is a discrepancy between the output of There are also other tests in test_foundry_prove.py that are skipping if the booster is used. I guess in the case of |
I don't think there are any remaining tests that skip if the booster is turned on, are there? |
From the perspective of the current engagement, we have been mostly using the booster, but recently we had to revert to the legacy backend for one of the proofs because of an expression that the booster was not simplifying. However, this shouldn't be a problem as long as there is still an option to switch back to the legacy backend if necessary. Regarding disabling the tests, I would prefer if we could wait until the engagement is over, just to be safe. If we need to temporarily switch back to the legacy backend, I would prefer not to risk the possibility of an update that breaks something having sneaked by undetected. But that depends on how likely it would be for that to happen. |
3b21552
to
17fd1b4
Compare
EDIT by @palinatolmach: this PR only makes
--use-booster
default and adds--no-use-booster
(both for Kontrol executable and tests) which can be used to switch to legacy backend. This PR doesn't disable legacy tests on CI for integration (considering that the the longer running ones were disabled by #171 and, as mentioned in the comment, there're tests that are skipped if the booster is used, the updated output is not compared for booster runs, and there's discrepancy between backends on the output oftest_foundry_auto_abstraction
). I factored disabling legacy CI tests into a separate issue.Original PR description by @ehildenb:
The tests on the legacy backend take very long, and we are already testing conformance in KEVM.
Any discrepancies between booster and legacy should be upstreamed as KClaim style tests to KEVM.
--use-booster
is default, pass--no-use-booster
to disable (both main executable and tests).