Enable publishing a Docker image from a branch #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palinatolmach
requested review from
anvacaru,
asavienko,
yiyi-wang-rv and
F-WRunTime
|
After a discussion with @yiyi-wang-rv, we decided to instead push the images to our private github packages, so they don't appear in our Dockerhub. |
yiyi-wang-rv
approved these changes
Dec 13, 2024
asavienko
reviewed
Dec 13, 2024
automergerpr-permission-manager
bot
deleted the
publish-branch-to-docker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/runtimeverification/kaas/pull/996.
This PR adds a workflow that allows publishing kontrol image to
Dockerhubghrc.io, i.e., our GitHub org packages, from a specific branch. The image will be namedruntimeverification/kontrol:ubuntu-jammy-{branch_name}.Additionally, it sanitizes a branch name first: for example, github actions disallow the
/symbol that appears in branch names — it gets replaced with-.Update: after a discussion with @yiyi-wang-rv, we decided to instead push the images to our private github packages, so they don't appear in our Dockerhub.